blaginin commented on PR #18185: URL: https://github.com/apache/datafusion/pull/18185#issuecomment-3433808204
This happened to be a bigger change than I expected, there are some really big and complicated tests, and if we just compare with a separate snapshot on every case, we'll add [+1K more lines](https://github.com/apache/datafusion/pull/16978/files#diff-dab838db3b99226d171afa057198d0dd9389f4be610f4017ad2facada685d68c) (like in the original PR). I'm doing something more complicated from the code point of view, but on the positive side the file keeps the same. I also think we may want to split some tests / and the file itself, but this may be the one to do on top of this PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
