adriangb commented on code in PR #18233:
URL: https://github.com/apache/datafusion/pull/18233#discussion_r2453320357
##########
datafusion/datasource/src/source.rs:
##########
@@ -285,21 +285,7 @@ impl ExecutionPlan for DataSourceExec {
}
fn partition_statistics(&self, partition: Option<usize>) ->
Result<Statistics> {
- if let Some(partition) = partition {
- let mut statistics = Statistics::new_unknown(&self.schema());
- if let Some(file_config) =
- self.data_source.as_any().downcast_ref::<FileScanConfig>()
- {
- if let Some(file_group) =
file_config.file_groups.get(partition) {
- if let Some(stat) = file_group.file_statistics(None) {
- statistics = stat.clone();
- }
- }
- }
- Ok(statistics)
- } else {
- Ok(self.data_source.statistics()?)
- }
Review Comment:
This was clearly buggy: in the `partition = None` path it returns
*projected* statistics (see current implementation in
`FileScanConfig::statistics`), if it took the `Some(partition)` path it
calculated the statistics but then never projected them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
