adriangb commented on code in PR #18233:
URL: https://github.com/apache/datafusion/pull/18233#discussion_r2463021017
##########
datafusion/datasource/src/source.rs:
##########
@@ -151,7 +151,7 @@ pub trait DataSource: Send + Sync + Debug {
fn scheduling_type(&self) -> SchedulingType {
SchedulingType::NonCooperative
}
- fn statistics(&self) -> Result<Statistics>;
+ fn partition_statistics(&self, partition: Option<usize>) ->
Result<Statistics>;
Review Comment:
Good call. I added `fn statistics()` back to `DataSource` trait as a
deprecated method and made it default to `partition_statistics(None)`. This
should make it fully backwards compatible for all implementations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
