paleolimbot commented on code in PR #17986:
URL: https://github.com/apache/datafusion/pull/17986#discussion_r2453429341
##########
datafusion/proto/src/logical_plan/from_proto.rs:
##########
@@ -628,12 +629,22 @@ pub fn parse_expr(
ExprType::Rollup(RollupNode { expr }) => Ok(Expr::GroupingSet(
GroupingSet::Rollup(parse_exprs(expr, registry, codec)?),
)),
- ExprType::Placeholder(PlaceholderNode { id, data_type }) => match
data_type {
+ ExprType::Placeholder(PlaceholderNode {
+ id,
+ data_type,
+ nullable,
+ metadata,
+ }) => match data_type {
None => Ok(Expr::Placeholder(Placeholder::new(id.clone(), None))),
Review Comment:
The field name carries no meaning (it's always overwritten in `.to_field()`)
and we already have the ID, although I'm happy to add if you feel strongly
about it.
##########
datafusion/sql/src/statement.rs:
##########
@@ -1264,7 +1266,7 @@ impl<S: ContextProvider> SqlToRel<'_, S> {
or_replace,
temporary,
name,
- return_type,
+ return_type: return_type.map(|f| f.data_type().clone()),
Review Comment:
I opened https://github.com/apache/datafusion/issues/18235 to track this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
