paleolimbot commented on PR #17986: URL: https://github.com/apache/datafusion/pull/17986#issuecomment-3437735619
Thank you for the reviews! > The only thing I would really like to see changed is renaming LiteralValue to something less confusing I went with `ScalarAndMetadata` from your suggestion list. Maybe `LogicalValue` (i.e., ScalarValue with logical type information) would work in some future world. > It would be nice to start wrapping this pattern into helper methods / extension traits . Thanks! I think that is a great solution for this PR (I love all things that consolidate these assumptions/operations). Probably also a `DFField` or `LogicalType` (== arrow type + metadata + nullability) would help with this...we're using a FieldRef in a very non-Field-y way and that will always be awkward. I'll put a note on one of the UDT threads (definitely a future consideration). > protobuf compatibility follow-on ticket I'm happy to file one if that is worth tracking (I didn't know that it was explicitly unsupported when I was doing the protobuf changes). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
