adriangb commented on PR #18192: URL: https://github.com/apache/datafusion/pull/18192#issuecomment-3445155246
I'm not clear on what the pros/cons of `&TaskContext` vs. `&dyn FunctionRegistry` are. I fear that some folks doing distributed (cc @gabotechs) want "more" there not less while other folks doing FFI (I'm guessing that's your use case right @timsaucer?) want "less", those two things seem to be opposed with each other. I guess as long as downcast matching is possible it may be okay to have the `&dyn FunctionRegistry` in the API and have implementations that want a `&TaskContext` do some downcasting? Either way that seems like a bigger discussion to have on your PR / proposal / issue. > +1 on the impl Into<DecodeContext<'a>> on the signatures as I think that will make for a much more ergonomic experience Hmm the only reason I see to do that is for backwards compatibility. The complexity and opacity introduced is not worth it otherwise IMO. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
