Jefffrey commented on PR #18192: URL: https://github.com/apache/datafusion/pull/18192#issuecomment-3445542589
> Thanks for the ping. One thing I was planning to do this weekend was to write up a PR to move from `TaskContext` to `dyn FunctionRegistry`, which `TaskContext` implements. I believe that the function registry is the only portion of the `TaskContext` we need. I believe this would simplify the code as we currently have two paths, some like `parse_physical_exprs` that take `&TaskContext` and some like `parse_expr` that take `&dyn FunctionRegistry`. > > I'm happy to put that PR in, but since you're digging into this bit of the code maybe we can include it? > > Also +1 on the `impl Into<DecodeContext<'a>>` on the signatures as I think that will make for a much more ergonomic experience. > > I think the core idea is a good one. In regards to `parse_expr`, I actually have a PR that changes it to accept `TaskContext` in order to support subqueries, see #18167 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
