bubulalabu commented on code in PR #18019:
URL: https://github.com/apache/datafusion/pull/18019#discussion_r2463781357
##########
datafusion/sql/tests/sql_integration.rs:
##########
@@ -3949,6 +3954,79 @@ fn test_double_quoted_literal_string() {
assert!(logical_plan("SELECT \"1\"").is_err());
}
+#[test]
+fn test_named_arguments_with_dialects() {
+ let sql = "SELECT my_func(arg1 => 'value1')";
Review Comment:
The purpose of this test was to understand how each dialect parses the
parameter name. Most dialects return `FunctionArg::Named`, the
`PostgresSQLDialect` returns `FunctionArg::ExprNamed`, and `MsSqlDialect`
doesn't return anything.
Yes, the SLT test cases cover the findings of this test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
