mbutrovich commented on PR #2528: URL: https://github.com/apache/datafusion-comet/pull/2528#issuecomment-3451653977
I had to turn off `countDeletes` in the `TestSparkReaderDeletes` suite because iceberg-rust (rightly) merges the equality deletes with table filters to evaluate them together in Arrow-rs's Parquet reader. This makes filtered rows and deleted rows indistinguishable, so the counts won't match. We still get correctness checks after skipped the counts though, so I'm confident in the tests. They still assert that: - Deletes are correctly applied (rows filtered) - The _deleted metadata column works - Equality and positional deletes function properly -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
