EmilyMatt commented on code in PR #18325:
URL: https://github.com/apache/datafusion/pull/18325#discussion_r2469841723
##########
datafusion/physical-plan/src/aggregates/row_hash.rs:
##########
@@ -967,6 +984,8 @@ impl GroupedHashAggregateStream {
let _ = self.update_memory_reservation();
let batch = RecordBatch::try_new(schema, output)?;
debug_assert!(batch.num_rows() > 0);
+
+ self.group_by_metrics.emitting_time.add_elapsed(start_time);
Review Comment:
update_memory_reservation() takes a mutable reference which cause ownership
issues unless I do a rather pointless clone of the metric before calling
timer() on it.
I can alternatively use a timer and drop it before the reservation call
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
