EmilyMatt commented on code in PR #18325:
URL: https://github.com/apache/datafusion/pull/18325#discussion_r2469866867
##########
datafusion/physical-plan/src/aggregates/row_hash.rs:
##########
@@ -430,6 +431,9 @@ pub(crate) struct GroupedHashAggregateStream {
/// Execution metrics
baseline_metrics: BaselineMetrics,
+
+ /// Aggregation-specific metrics
+ group_by_metrics: GroupByMetrics,
Review Comment:
I think this will become a performance hit, I'd rather keep metrics concrete
to avoid syscalls
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
