cj-zhukov commented on code in PR #18289:
URL: https://github.com/apache/datafusion/pull/18289#discussion_r2480263644


##########
datafusion-examples/examples/advanced_udf/main.rs:
##########
@@ -0,0 +1,78 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+//! # Advanced UDF/UDAF/UDWF/Asynchronous UDF Examples
+//!
+//! This example demonstrates advanced user-defined functions in DataFusion.
+//!
+//! ## Usage
+//! ```bash
+//! cargo run --example advanced_udf -- [udf|udaf|udwf|async_udf]
+//! ```
+//!
+//! Each subcommand runs a corresponding example:
+//! - `udf` — user defined scalar function example
+//! - `udaf` — user defined aggregate function example
+//! - `udwf` — user defined window function example
+//! - `async_udf` — asynchronous user defined function example
+
+mod async_udf;
+mod udaf;
+mod udf;
+mod udwf;
+
+use std::str::FromStr;
+
+use datafusion::error::{DataFusionError, Result};
+
+enum ExampleKind {
+    Udf,
+    Udaf,
+    Udwf,
+    AsyncUdf,
+}
+
+impl FromStr for ExampleKind {

Review Comment:
   Good point - indeed, the example entry files follow a similar pattern. It 
could make sense to refactor this into a shared helper or macro in the future 
to keep them in sync. For now, I kept this consistent with the existing example 
structure.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to