alamb commented on code in PR #18415:
URL: https://github.com/apache/datafusion/pull/18415#discussion_r2482495868
##########
datafusion/common/src/dfschema.rs:
##########
@@ -353,13 +353,13 @@ impl DFSchema {
/// Returns an immutable reference of a specific `Field` instance selected
using an
/// offset within the internal `fields` vector
- pub fn field(&self, i: usize) -> &Field {
+ pub fn field(&self, i: usize) -> &FieldRef {
Review Comment:
the changes in this file are the public API changes -- they return a
reference to the `Arc` rather than what is in the `Arc` meaning the callsite
can clone the arcs when needed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
