alamb commented on code in PR #18415:
URL: https://github.com/apache/datafusion/pull/18415#discussion_r2518329443
##########
datafusion/expr/src/expr_schema.rs:
##########
Review Comment:
this is called as part of `Expr::nullable` and `Expr::nullable` so it is a
very hot path on planning
##########
datafusion/common/src/datatype.rs:
##########
@@ -130,6 +178,32 @@ pub trait FieldExt {
}
impl FieldExt for Field {
+ fn renamed(self, new_name: &str) -> Self {
Review Comment:
I added several new methods to avoid cloning when it is unnecesary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
