alamb commented on code in PR #18373:
URL: https://github.com/apache/datafusion/pull/18373#discussion_r2482668741
##########
datafusion/physical-plan/src/memory.rs:
##########
@@ -165,6 +167,7 @@ impl LazyMemoryExec {
/// Create a new lazy memory execution plan
pub fn try_new(
schema: SchemaRef,
+ projection: Option<Vec<usize>>,
Review Comment:
this is technically a breaking API change -- it is minor but still breaking
What would you think about adding a new method like
```rust
impl LazyMemoryExec {
pub fn with_projection(projection: Option<Vec<usize>>) -> Self { ... }
}
```
instead and leave the signature of `try_new` the same
That would avoid the API breakage (and likely reduce the size of this PR a
bit as many callsites would not have to be changed)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
