codetyri0n commented on PR #18417: URL: https://github.com/apache/datafusion/pull/18417#issuecomment-3476748642
> I haven't had a chance to go over this in detail but can we add some tests to the .slt to test where the timestamp is being provided with a timezone? I didn't see any from a quick look. with the introduction of the tests recommended, it led to making extract independent from date_part --> it does not use the date_part udf. Lmk if you have any concerns. Summarizing it here: - date_part AND extract are now timezone config efficient - extract is now registered as a separate datetime function - corresponding changes made to mod.rs files and planner - slt files and the test cases impacted have been modified accordingly (verified locally) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
