codetyri0n commented on PR #18417: URL: https://github.com/apache/datafusion/pull/18417#issuecomment-3510895741
> I just don't see the need for having extract being another function in this PR. Little late to realise the overdo myself 😅. However I have brought it back within date_part as before and have also added more robust test cases recommended (like improper offsets) with code addition/tweaks for the same. I am unclear on how to make named timezones like 'Europe/Brussels' work and have for now, commented out that specific test case. I feel we can push this as part of the latest release since this is a candidate and then get started on making the 'named timezones' scenario work with some help, if it is within the scope. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
