Weijun-H commented on code in PR #18432:
URL: https://github.com/apache/datafusion/pull/18432#discussion_r2484762555
##########
datafusion/functions-nested/src/extract.rs:
##########
@@ -1028,4 +1194,71 @@ mod tests {
fixed_size_list_type
);
}
+
+ #[test]
+ fn test_array_slice_list_view_basic() -> Result<()> {
+ let values: ArrayRef = Arc::new(Int32Array::from(vec![1, 2, 3, 4, 5]));
+ let offsets = ScalarBuffer::from(vec![0, 3]);
+ let sizes = ScalarBuffer::from(vec![3, 2]);
+ let field = Arc::new(Field::new("item", DataType::Int32, true));
+ let array = ListViewArray::new(field, offsets, sizes, values, None);
+
+ let from = Int64Array::from(vec![2, 1]);
+ let to = Int64Array::from(vec![3, 2]);
+
+ let result = general_list_view_array_slice::<i32>(
+ &array,
+ &from,
+ &to,
+ None::<&Int64Array>,
+ )?;
+ let result = result.as_ref().as_list_view::<i32>();
+
+ assert_eq!(list_view_values(result), vec![vec![2, 3], vec![4, 5]]);
+ Ok(())
+ }
+
+ #[test]
+ fn test_array_slice_list_view_non_monotonic_offsets() -> Result<()> {
+ // First list references the tail of the values buffer, second list
references the head.
+ let values: ArrayRef = Arc::new(Int32Array::from(vec![1, 2, 3, 4, 5]));
+ let offsets = ScalarBuffer::from(vec![3, 0]);
+ let sizes = ScalarBuffer::from(vec![2, 3]);
+ let field = Arc::new(Field::new("item", DataType::Int32, true));
+ let array = ListViewArray::new(field, offsets, sizes, values, None);
+
+ let from = Int64Array::from(vec![1, 1]);
+ let to = Int64Array::from(vec![2, 2]);
+
+ let result = general_list_view_array_slice::<i32>(
+ &array,
+ &from,
+ &to,
+ None::<&Int64Array>,
+ )?;
+ let result = result.as_ref().as_list_view::<i32>();
+
+ assert_eq!(list_view_values(result), vec![vec![4, 5], vec![1, 2]]);
+ Ok(())
+ }
+
+ #[test]
+ fn test_array_slice_list_view_negative_stride() -> Result<()> {
+ let values: ArrayRef = Arc::new(Int32Array::from(vec![1, 2, 3, 4, 5]));
+ let offsets = ScalarBuffer::from(vec![0, 3]);
+ let sizes = ScalarBuffer::from(vec![3, 2]);
+ let field = Arc::new(Field::new("item", DataType::Int32, true));
+ let array = ListViewArray::new(field, offsets, sizes, values, None);
+
+ let from = Int64Array::from(vec![3, 2]);
+ let to = Int64Array::from(vec![1, 1]);
+ let stride = Int64Array::from(vec![-1, -1]);
+
+ let result =
+ general_list_view_array_slice::<i32>(&array, &from, &to,
Some(&stride))?;
+ let result = result.as_ref().as_list_view::<i32>();
+
+ assert_eq!(list_view_values(result), vec![vec![3, 2, 1], vec![5, 4]]);
+ Ok(())
+ }
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
