Weijun-H commented on code in PR #18432:
URL: https://github.com/apache/datafusion/pull/18432#discussion_r2492020717
##########
datafusion/functions-nested/src/extract.rs:
##########
@@ -644,6 +692,106 @@ where
)?))
}
+fn general_list_view_array_slice<O: OffsetSizeTrait>(
+ array: &GenericListViewArray<O>,
+ from_array: &Int64Array,
+ to_array: &Int64Array,
+ stride: Option<&Int64Array>,
+) -> Result<ArrayRef>
+where
+ i64: TryInto<O>,
+{
+ let values = array.values();
+ let original_data = values.to_data();
+ let capacity = Capacities::Array(original_data.len());
+ let field = match array.data_type() {
+ ListView(field) | LargeListView(field) => Arc::clone(field),
+ other => {
+ return internal_err!("array_slice got unexpected data type: {}",
other);
+ }
+ };
+
+ let mut mutable =
+ MutableArrayData::with_capacities(vec![&original_data], true,
capacity);
+
+ // We must build `offsets` and `sizes` buffers manually as ListView does
not enforce
+ // monotonically increasing offsets.
+ let mut offsets = Vec::with_capacity(array.len());
+ let mut sizes = Vec::with_capacity(array.len());
+ let mut current_offset = O::usize_as(0);
+ let mut null_builder = NullBufferBuilder::new(array.len());
+
+ for row_index in 0..array.len() {
+ // Propagate NULL semantics: any NULL input yields a NULL output slot.
+ if array.is_null(row_index)
+ || from_array.is_null(row_index)
+ || to_array.is_null(row_index)
+ {
+ null_builder.append_null();
+ offsets.push(current_offset);
+ sizes.push(O::usize_as(0));
+ continue;
+ }
+ null_builder.append_non_null();
+
+ let len = array.value_size(row_index);
+
+ // Empty arrays always return an empty array.
+ if len == O::usize_as(0) {
+ offsets.push(current_offset);
+ sizes.push(O::usize_as(0));
+ continue;
+ }
+
+ let slice_plan = compute_slice_plan::<O>(
+ len,
+ from_array.value(row_index),
+ to_array.value(row_index),
+ stride.map(|s| s.value(row_index)),
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
