adriangb commented on code in PR #18449:
URL: https://github.com/apache/datafusion/pull/18449#discussion_r2484954956
##########
datafusion/proto/src/physical_plan/to_proto.rs:
##########
@@ -315,7 +315,10 @@ pub fn serialize_physical_expr(
expr_type:
Some(protobuf::physical_expr_node::ExprType::InList(Box::new(
protobuf::PhysicalInListNode {
expr: Some(Box::new(serialize_physical_expr(expr.expr(),
codec)?)),
- list: serialize_physical_exprs(expr.list(), codec)?,
+ // TODO: serialize the inner ArrayRef directly to avoid
materialization into literals
+ // by extending the protobuf definition to support both
representations and adding a public
+ // accessor method to InListExpr to get the inner ArrayRef
Review Comment:
I'll create a followup issue once we merge this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
