adriangb commented on code in PR #18449:
URL: https://github.com/apache/datafusion/pull/18449#discussion_r2507641597
##########
datafusion/physical-expr/src/expressions/in_list.rs:
##########
@@ -65,13 +65,8 @@ impl Debug for InListExpr {
}
}
-/// A type-erased container of array elements
-pub trait Set: Send + Sync {
- fn contains(&self, v: &dyn Array, negated: bool) -> Result<BooleanArray>;
- fn has_nulls(&self) -> bool;
-}
Review Comment:
We get rid of the `Set` trait. The only implementer was `ArraySet`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
