bubulalabu commented on code in PR #18389: URL: https://github.com/apache/datafusion/pull/18389#discussion_r2485543492
########## docs/source/library-user-guide/functions/adding-udfs.md: ########## @@ -1047,6 +1047,48 @@ The output will be like: ... ``` +### Named Arguments for Window UDFs Review Comment: E.g. initially I explicitly tested if the order for unnamed and named arguments works for all kinds of UDFs. It's fine to test it only for one kind as all of them use the same underlying implementation. If that wasn't what you were referring to initially, it'd be great if you'd elaborate a bit on your initial comment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
