vegarsti commented on code in PR #18424:
URL: https://github.com/apache/datafusion/pull/18424#discussion_r2487758392
##########
datafusion/functions-nested/src/reverse.rs:
##########
@@ -183,6 +196,50 @@ fn general_array_reverse<O: OffsetSizeTrait +
TryFrom<i64>>(
)?))
}
+fn list_view_reverse<O: OffsetSizeTrait + TryFrom<i64>>(
Review Comment:
Alright, I tried the benchmark here #18425 with `array_len` of 10k (it's
100k on the branch), using MutableData is way worse 🫨 Baseline is the code on
this PR, the code from this snippet is
[here](https://gist.github.com/vegarsti/28be107e53670428750874bfc0cdb621).
```
array_reverse time: [44.858 µs 44.865 µs 44.874 µs]
change: [+545.75% +547.46% +549.17%] (p = 0.00 <
0.05)
Performance has regressed.
```
This indicates it might be worth using `take` instead of `MutableData` on
the regular array one too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
