Jefffrey commented on code in PR #18424:
URL: https://github.com/apache/datafusion/pull/18424#discussion_r2488546840
##########
datafusion/functions-nested/src/reverse.rs:
##########
@@ -219,3 +300,148 @@ fn fixed_size_array_reverse(
Some(nulls.into()),
)?))
}
+
+#[cfg(test)]
+mod tests {
+ use crate::reverse::list_view_reverse;
+ use arrow::{
+ array::{
+ AsArray, GenericListViewArray, Int32Array, LargeListViewArray,
ListViewArray,
+ OffsetSizeTrait,
+ },
+ buffer::{NullBuffer, ScalarBuffer},
+ datatypes::{DataType, Field, Int32Type},
+ };
+ use datafusion_common::Result;
+ use std::sync::Arc;
+
+ fn list_view_values<O: OffsetSizeTrait>(
+ array: &GenericListViewArray<O>,
+ ) -> Vec<Option<Vec<i32>>> {
+ array
+ .iter()
+ .map(|x| x.map(|x|
x.as_primitive::<Int32Type>().values().to_vec()))
+ .collect()
+ }
+
+ #[test]
+ fn test_reverse_list_view() -> Result<()> {
+ let field = Arc::new(Field::new("a", DataType::Int32, false));
+ let offsets = ScalarBuffer::from(vec![0, 1, 6, 6]);
+ let sizes = ScalarBuffer::from(vec![1, 5, 0, 3]);
+ let values = Arc::new(Int32Array::from(vec![1, 2, 3, 4, 5, 6, 7, 8,
9]));
+ let nulls = Some(NullBuffer::from(vec![true, true, false, true]));
+ let list_view = ListViewArray::new(field, offsets, sizes, values,
nulls);
+ let result = list_view_reverse(
+ &list_view,
+ &Arc::new(Field::new("test", DataType::Int32, true)),
+ )?;
+ let reversed = list_view_values(result.as_list_view::<i32>());
+ let expected = vec![
+ Some(vec![1]),
+ Some(vec![6, 5, 4, 3, 2]),
+ None,
+ Some(vec![9, 8, 7]),
+ ];
+ assert_eq!(expected, reversed);
+ Ok(())
+ }
+
+ #[test]
+ fn test_reverse_large_list_view() -> Result<()> {
+ let field = Arc::new(Field::new("a", DataType::Int32, false));
+ let offsets = ScalarBuffer::from(vec![0, 1, 6, 6]);
+ let sizes = ScalarBuffer::from(vec![1, 5, 0, 3]);
+ let values = Arc::new(Int32Array::from(vec![1, 2, 3, 4, 5, 6, 7, 8,
9]));
+ let nulls = Some(NullBuffer::from(vec![true, true, false, true]));
+ let list_view = LargeListViewArray::new(field, offsets, sizes, values,
nulls);
+ let result = list_view_reverse(
+ &list_view,
+ &Arc::new(Field::new("test", DataType::Int32, true)),
+ )?;
+ let reversed = list_view_values(result.as_list_view::<i64>());
+ let expected = vec![
+ Some(vec![1]),
+ Some(vec![6, 5, 4, 3, 2]),
+ None,
+ Some(vec![9, 8, 7]),
+ ];
+ assert_eq!(expected, reversed);
+ Ok(())
+ }
+
+ #[test]
+ fn test_reverse_list_view_out_of_order() -> Result<()> {
+ let field = Arc::new(Field::new("a", DataType::Int32, false));
+ let offsets = ScalarBuffer::from(vec![6, 1, 6, 0]); // out of order
+ let sizes = ScalarBuffer::from(vec![3, 5, 0, 1]);
+ let values = Arc::new(Int32Array::from(vec![
+ 1, // fourth array: offset 0, size 1
+ 2, 3, 4, 5, 6, // second array: offset 1, size 5
+ // third array: offset 6, size 0 (and null)
+ 7, 8, 9, // first array: offset 6, size 3
+ ]));
+ let nulls = Some(NullBuffer::from(vec![true, true, false, true]));
+ let list_view = ListViewArray::new(field, offsets, sizes, values,
nulls);
+ let result = list_view_reverse(
+ &list_view,
+ &Arc::new(Field::new("test", DataType::Int32, true)),
+ )?;
+ let reversed = list_view_values(result.as_list_view::<i32>());
+ let expected = vec![
+ Some(vec![9, 8, 7]),
+ Some(vec![6, 5, 4, 3, 2]),
+ None,
+ Some(vec![1]),
+ ];
+ assert_eq!(expected, reversed);
+ Ok(())
+ }
+
+ #[test]
+ fn test_reverse_list_view_with_nulls() -> Result<()> {
+ let field = Arc::new(Field::new("a", DataType::Int32, false));
+ let offsets = ScalarBuffer::from(vec![16, 1, 6, 0]); // out of order
+ let sizes = ScalarBuffer::from(vec![3, 5, 10, 1]);
+ let values = Arc::new(Int32Array::from(vec![
+ 1, // fourth array: offset 0, size 1
+ 2, 3, 4, 5, 6, // second array: offset 1, size 5
+ 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, // third array: offset 6, size 10
+ 7, 8, 9, // first array: offset 6, size 3
+ ]));
+ let nulls = Some(NullBuffer::from(vec![true, true, false, true]));
+ let list_view = ListViewArray::new(field, offsets, sizes, values,
nulls);
+ let result = list_view_reverse(
+ &list_view,
+ &Arc::new(Field::new("test", DataType::Int32, true)),
+ )?;
+ let reversed = list_view_values(result.as_list_view::<i32>());
+ let expected = vec![
+ Some(vec![9, 8, 7]),
+ Some(vec![6, 5, 4, 3, 2]),
+ None,
+ Some(vec![1]),
+ ];
+ assert_eq!(expected, reversed);
+ Ok(())
+ }
+
+ #[test]
+ fn test_reverse_list_view_empty() -> Result<()> {
Review Comment:
Could we also have a test case where its all nulls?
##########
datafusion/functions-nested/src/reverse.rs:
##########
@@ -183,6 +196,50 @@ fn general_array_reverse<O: OffsetSizeTrait +
TryFrom<i64>>(
)?))
}
+fn list_view_reverse<O: OffsetSizeTrait + TryFrom<i64>>(
Review Comment:
Sounds good to go with take in that case
##########
datafusion/functions-nested/src/reverse.rs:
##########
@@ -183,6 +195,75 @@ fn general_array_reverse<O: OffsetSizeTrait +
TryFrom<i64>>(
)?))
}
+fn list_view_reverse<O: OffsetSizeTrait + TryFrom<i64>>(
Review Comment:
Might need to merge up from main, the trait bound is still here on the new
function
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
