iffyio commented on code in PR #2083:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/2083#discussion_r2489376793
##########
src/ast/ddl.rs:
##########
@@ -3559,6 +3583,8 @@ impl fmt::Display for AlterTable {
fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
if self.iceberg {
write!(f, "ALTER ICEBERG TABLE ")?;
+ } else if self.dynamic {
+ write!(f, "ALTER DYNAMIC TABLE ")?;
Review Comment:
Can we replace the `iceberg:bool` field with an enum instead? thinking so
that we don't accumulate booleans over time (e.g. its not clear or enforceable
that iceberg and dynamic are mutually exclusive).
e.g.
```rust
enum AlterTableType {
Iceberg
Dynamic
}
Statement::AlterTable { table_type: AlterTableType }
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
