comphead commented on code in PR #2699:
URL: https://github.com/apache/datafusion-comet/pull/2699#discussion_r2496092212
##########
fuzz-testing/src/main/scala/org/apache/comet/fuzz/ComparisonTool.scala:
##########
@@ -31,6 +31,8 @@ class ComparisonToolConf(arguments: Seq[String]) extends
ScallopConf(arguments)
opt[String](required = true, descr = "Folder with Spark produced results
in Parquet format")
val inputCometFolder: ScallopOption[String] =
opt[String](required = true, descr = "Folder with Comet produced results
in Parquet format")
+ val tolerance: ScallopOption[Double] =
+ opt[Double](default = Some(0.000001), descr = "Tolerance for floating
point comparisons")
Review Comment:
@andygrove WDYT the value we can tolerate for FP comparisons?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
