andygrove commented on code in PR #2699:
URL: https://github.com/apache/datafusion-comet/pull/2699#discussion_r2498966288
##########
fuzz-testing/src/main/scala/org/apache/comet/fuzz/ComparisonTool.scala:
##########
@@ -31,6 +31,8 @@ class ComparisonToolConf(arguments: Seq[String]) extends
ScallopConf(arguments)
opt[String](required = true, descr = "Folder with Spark produced results
in Parquet format")
val inputCometFolder: ScallopOption[String] =
opt[String](required = true, descr = "Folder with Comet produced results
in Parquet format")
+ val tolerance: ScallopOption[Double] =
+ opt[Double](default = Some(0.000001), descr = "Tolerance for floating
point comparisons")
Review Comment:
Looking at the data from issue #2666:
The difference between 1.1393133533510004E10 and 1.1393133533510002E10 is
0.000002
The difference between 3.025092059900001E8 and 3.0250920599E8 is 0.0000001
The difference between -3.1431747315200024E9 and -3.1431747315200014E9 is
0.000001
So I think 0.000002 should be sufficient to close the issue. It is good that
this is configurable as a CLI argument.
```
Spark:
NULL,NULL,1.1393133533510002E10,3.025092059900001E8,-3.1431747315200024E9
Comet: NULL,NULL,1.1393133533510004E10,3.0250920599E8,-3.1431747315200014E9
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
