2010YOUY01 commented on PR #18488: URL: https://github.com/apache/datafusion/pull/18488#issuecomment-3495468054
> Considering the results, I think we should move it to `ExplainAnalyzeLevel::Dev` then? It's running in a noisy cloud environment, and tpch_mem takes quite short time, so it might not be accurate. I’ve verified this with tpch_mem10 locally, and it actually slows down several queries. I tried to make this count distinct indices faster (and sent a PR https://github.com/feniljain/datafusion/pull/2), and after that I think the result looks good: ``` -------------------- Benchmark tpch_mem_sf10.json -------------------- ┏━━━━━━━━━━━━━━┳━━━━━━━━━━━━┳━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓ ┃ Query ┃ main ┃ pr-18488-opt ┃ Change ┃ ┡━━━━━━━━━━━━━━╇━━━━━━━━━━━━╇━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩ │ QQuery 1 │ 224.33 ms │ 225.34 ms │ no change │ │ QQuery 2 │ 52.61 ms │ 53.36 ms │ no change │ │ QQuery 3 │ 116.20 ms │ 115.79 ms │ no change │ │ QQuery 4 │ 70.10 ms │ 69.32 ms │ no change │ │ QQuery 5 │ 199.10 ms │ 198.30 ms │ no change │ │ QQuery 6 │ 50.64 ms │ 46.92 ms │ +1.08x faster │ │ QQuery 7 │ 474.45 ms │ 479.40 ms │ no change │ │ QQuery 8 │ 158.07 ms │ 157.65 ms │ no change │ │ QQuery 9 │ 341.40 ms │ 336.64 ms │ no change │ │ QQuery 10 │ 143.37 ms │ 150.52 ms │ no change │ │ QQuery 11 │ 41.77 ms │ 42.82 ms │ no change │ │ QQuery 12 │ 146.51 ms │ 147.67 ms │ no change │ │ QQuery 13 │ 118.36 ms │ 120.90 ms │ no change │ │ QQuery 14 │ 25.81 ms │ 25.68 ms │ no change │ │ QQuery 15 │ 54.43 ms │ 55.78 ms │ no change │ │ QQuery 16 │ 47.39 ms │ 47.76 ms │ no change │ │ QQuery 17 │ 414.56 ms │ 417.56 ms │ no change │ │ QQuery 18 │ 1042.19 ms │ 1074.00 ms │ no change │ │ QQuery 19 │ 77.35 ms │ 80.07 ms │ no change │ │ QQuery 20 │ 97.83 ms │ 98.10 ms │ no change │ │ QQuery 21 │ 4416.18 ms │ 4322.24 ms │ no change │ │ QQuery 22 │ 35.76 ms │ 35.70 ms │ no change │ └──────────────┴────────────┴──────────────┴───────────────┘ ┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━┓ ┃ Benchmark Summary ┃ ┃ ┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━┩ │ Total Time (main) │ 8348.40ms │ │ Total Time (pr-18488-opt) │ 8301.53ms │ │ Average Time (main) │ 379.47ms │ │ Average Time (pr-18488-opt) │ 377.34ms │ │ Queries Faster │ 1 │ │ Queries Slower │ 0 │ │ Queries with No Change │ 21 │ │ Queries with Failure │ 0 │ └─────────────────────────────┴───────────┘ ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
