comphead opened a new pull request, #2726:
URL: https://github.com/apache/datafusion-comet/pull/2726
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
Related to #2721
Closes #.
## Rationale for this change
Currently windows functions are enabled by default, however we can spot
numerous correctness issues which need to be addressed separately. List of
correctness issues can be found in #2721
```
- window: MIN and MAX with ORDER BY (383 milliseconds)
- window: COUNT with ROWS BETWEEN UNBOUNDED PRECEDING AND CURRENT ROW ***
FAILED *** (196 milliseconds)
Results do not match for query:
--
- window: SUM with ROWS BETWEEN CURRENT ROW AND UNBOUNDED FOLLOWING ***
FAILED *** (190 milliseconds)
Results do not match for query:
--
- window: AVG with ROWS BETWEEN 1 PRECEDING AND 1 FOLLOWING *** FAILED ***
(183 milliseconds)
Results do not match for query:
--
- window: LAG with default offset *** FAILED *** (192 milliseconds)
Results do not match for query:
--
- window: LAG with offset 2 and default value *** FAILED *** (184
milliseconds)
Results do not match for query:
--
- window: LEAD with default offset *** FAILED *** (176 milliseconds)
Results do not match for query:
--
- window: LEAD with offset 2 and default value *** FAILED *** (173
milliseconds)
Results do not match for query:
- window: multiple window functions in single query *** FAILED *** (195
milliseconds)
Results do not match for query:
- window: ROWS BETWEEN with negative offset *** FAILED *** (184 milliseconds)
Results do not match for query:
--
- window: all ranking functions together *** FAILED *** (197 milliseconds)
Results do not match for query:
```
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
## How are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are
they covered by existing tests)?
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
