comphead commented on code in PR #2726:
URL: https://github.com/apache/datafusion-comet/pull/2726#discussion_r2506240503
##########
common/src/main/scala/org/apache/comet/CometConf.scala:
##########
@@ -251,7 +251,7 @@ object CometConf extends ShimCometConf {
val COMET_EXEC_EXPAND_ENABLED: ConfigEntry[Boolean] =
createExecEnabledConfig("expand", defaultValue = true)
val COMET_EXEC_WINDOW_ENABLED: ConfigEntry[Boolean] =
- createExecEnabledConfig("window", defaultValue = true)
+ createExecEnabledConfig("window", defaultValue = false)
Review Comment:
I think we need to double check how Comet works with `exec.*.enabled`
params.
In this example I disabled `windows` and actually expected that Comet would
fallback silently to Spark for windows, however I got a bunch of weirdest
issues, including corrupted schema on native side
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
