alamb commented on issue #17558: URL: https://github.com/apache/datafusion/issues/17558#issuecomment-3502046516
@shehabgamin -- thank you > > I made a PR to upgrade delta.rs and I didn't find anything show stopping > > ``` > > * [feat: update to DataFusion 51.0.0 delta-io/delta-rs#3921](https://github.com/delta-io/delta-rs/pull/3921) > > ``` > > [@alamb](https://github.com/alamb) We should coordinate on the next release. It looks like we can save some duplicated effort: [lakehq/delta-rs#2](https://github.com/lakehq/delta-rs/pull/2) Thanks! Yes that would be great -- it would be super helpful. I started my testing about the same time as @lonless9 filed https://github.com/delta-io/delta-rs/pull/3921 -- hopefully next time we'll avoid the duplication > ## Testing With Sail > [@lonless9](https://github.com/lonless9) made a PR to upgrade to DataFusion 51: [lakehq/sail#1031](https://github.com/lakehq/sail/pull/1031) ❤️ > ``` > Expects PARTITION BY expression to be ordered > ``` > > Here is the test in question: https://github.com/lakehq/sail/blob/8bc2a05d595f02aba3a23fcd26aef81df36a7b96/python/pysail/tests/spark/test_execution.py#L124-L148 Thanks -- I looked at that briefly at that test and it isn't clear where "Expects PARTITION BY expression to be ordered" is coming from. While the window function does have a `partition by` expression, I don't see why the partition by would be ordered. I filed a ticket to track it - https://github.com/apache/datafusion/issues/18527 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
