alamb opened a new pull request, #18536: URL: https://github.com/apache/datafusion/pull/18536
## Which issue does this PR close? - Related to https://github.com/apache/datafusion/issues/17801 ## Rationale for this change We made a change that causes a regression in planning one of the tpcds benchmarks (see https://github.com/apache/datafusion/issues/17801) However, only the planning benchmarks saw the problem, all the normal CI test pass. We have a `tpchds_planning` suite to test for exactly this scenario, so that test should have failed as well Debugging more it turns out that the test somewhat non obviously calls `optimize` twice on the LogicalPlan which in this case masks the error. ## What changes are included in this PR? 1. avoid calling optimize twice in the test Note that due to https://github.com/apache/datafusion/issues/17801 the test now fails like this: ```shell cargo test --test tpcds_planning ``` ``` ---- tpcds_physical_q75 stdout ---- Error: Internal("Physical input schema should be the same as the one converted from logical input schema. Differences: \n\t- field nullability at index 5 [sales_cnt]: (physical) true vs (logical) false\n\t- field nullability at index 6 [sales_amt]: (physical) true vs (logical) false") ``` ## Are these changes tested? They are only tests ## Are there any user-facing changes? No, this is an internal only change -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
