2010YOUY01 commented on code in PR #18532: URL: https://github.com/apache/datafusion/pull/18532#discussion_r2505973071
########## datafusion/expr/src/lib.rs: ########## @@ -24,6 +24,12 @@ // https://github.com/apache/datafusion/issues/11143 #![deny(clippy::clone_on_ref_ptr)] +// https://github.com/apache/datafusion/issues/18503 +#![deny(clippy::needless_pass_by_value)] +// This lint rule is enforced in `../Cargo.toml`, but it's okay to skip them in tests +// See details in https://github.com/apache/datafusion/issues/18503 Review Comment: ```suggestion ``` This comment seem to be obsolete, I believe the above issue link is enough to explain the rationale. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
