adriangb commented on code in PR #18449:
URL: https://github.com/apache/datafusion/pull/18449#discussion_r2508165952
##########
datafusion/physical-expr/src/expressions/in_list.rs:
##########
@@ -474,16 +427,46 @@ pub fn in_list(
)))
}
+/// Create a new InList expression directly from an array, bypassing
expression evaluation.
+///
+/// This is more efficient than `in_list()` when you already have the list as
an array,
+/// as it avoids the conversion: ArrayRef -> Vec<PhysicalExpr> -> ArrayRef ->
ArraySet.
+/// Instead it goes directly: ArrayRef -> ArraySet.
+///
+/// The `list` field will be empty when using this constructor, as the array
is stored
+/// directly in the static filter.
+pub fn in_list_from_array(
Review Comment:
Yeah I agree, I was just following the existing patterns
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
