2010YOUY01 commented on PR #18457: URL: https://github.com/apache/datafusion/pull/18457#issuecomment-3510382219
> I do find one thing annoying, but I don't know if it's impacting this PR. We are calling these `ArrowFileSource` and `ArrowStreamSource`, but both of them are **file** readers, right? It's just that one is stored in a random access approach and one is stored in a stream approach. When I see the name `ArrowStreamSource` I would intuitively think that means some kind of Arrow stream. Especially if I see the two of those next to each other, my intuition would be that one is a streaming source and one is a file source. I know you're reusing the terminology in the [Arrow spec](https://arrow.apache.org/docs/python/ipc.html), so again I may be overthinking this. Perhaps `ArrowIPCStreamSource` if that's the formal term 🤔 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
