corasaurus-hex commented on code in PR #18457:
URL: https://github.com/apache/datafusion/pull/18457#discussion_r2511112801
##########
datafusion/datasource-arrow/src/file_format.rs:
##########
@@ -176,14 +184,33 @@ impl FileFormat for ArrowFormat {
async fn create_physical_plan(
&self,
- _state: &dyn Session,
+ state: &dyn Session,
conf: FileScanConfig,
) -> Result<Arc<dyn ExecutionPlan>> {
+ let object_store =
state.runtime_env().object_store(&conf.object_store_url)?;
+ let object_location = &conf
+ .file_groups
+ .first()
+ .ok_or_else(|| internal_datafusion_err!("No files found in file
group"))?
+ .files()
+ .first()
Review Comment:
I guess that would be a limitation of this implementation, that it assumes
that all the arrow files are in the same format. I think it's an acceptable
limitation, under the assumption that most people will be querying files on the
other side of a data pipeline that produces all the same format.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
