coderfender commented on PR #2600: URL: https://github.com/apache/datafusion-comet/pull/2600#issuecomment-3513482104
@comphead , great point. The reason is the same as the special implementation as @sunchao for `Decimal` addition (`SumDecimal` implementation) . If we truly want a nartive window expression, we might want to implement sliding window accumulator (in [df](https://docs.rs/datafusion-functions-aggregate/latest/src/datafusion_functions_aggregate/sum.rs.html)) . I plan to support native sliding windows for both sum decimal and sum int functions in subsequent PRs (once I finish ANSI support for `avg` function) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
