codetyri0n commented on PR #18615:
URL: https://github.com/apache/datafusion/pull/18615#issuecomment-3518178712
@martin-g @Omega359 This PR is a direct port of #18417 which got really
messy (my apologies 🥲) due to a whole lot of unwanted commits. Closed that so
that we could have a clean PR.
This contains the commit which addressed @martin-g thoughts for :
1. handling offsets that included tz such as +02:30 and the subsequent test
cases.
2. minor error handling suggestions and tweaks.
3. refactor of a common function - implemented in mod.rs as a helper
function and correspondingly used in to_local_time and date_part files.
Improvements that could be made for future releases:
1. Named timezone support ('Europe/Brussels' , 'Asia/Beijing' etc) that I
was unclear on how to carry forward with.
Lmk wdyt (my apologies again for the messy closure and reopening of a
separate PR for this)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
