petern48 commented on code in PR #18575:
URL: https://github.com/apache/datafusion/pull/18575#discussion_r2515786169
##########
datafusion/datasource-parquet/src/reader.rs:
##########
@@ -314,3 +334,56 @@ impl FileMetadata for CachedParquetMetaData {
HashMap::from([("page_index".to_owned(), page_index.to_string())])
}
}
+
+#[cfg(test)]
+mod tests {
+ use super::*;
+ use datafusion_execution::cache::cache_unit::DefaultFilesMetadataCache;
+ use object_store::{memory::InMemory, path::Path, ObjectMeta, ObjectStore};
+
+ #[tokio::test]
+ async fn cached_parquet_file_reader() {
Review Comment:
Makes sense. It did feel very odd to write a test for it. I was thinking we
should protect against removing `new()`, but I guess there isn't a reason
someone would just remove the constructor and go back to building the struct
manually in that code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
