alamb commented on code in PR #17813:
URL: https://github.com/apache/datafusion/pull/17813#discussion_r2515975198
##########
datafusion/physical-expr/src/expressions/case.rs:
##########
@@ -1282,15 +1283,57 @@ impl PhysicalExpr for CaseExpr {
}
fn nullable(&self, input_schema: &Schema) -> Result<bool> {
- // this expression is nullable if any of the input expressions are
nullable
- let then_nullable = self
+ let nullable_then = self
.body
.when_then_expr
.iter()
- .map(|(_, t)| t.nullable(input_schema))
- .collect::<Result<Vec<_>>>()?;
- if then_nullable.contains(&true) {
- Ok(true)
+ .filter_map(|(w, t)| {
+ let is_nullable = match t.nullable(input_schema) {
+ // Pass on error determining nullability verbatim
+ Err(e) => return Some(Err(e)),
+ Ok(n) => n,
+ };
+
+ // Branches with a then expression that is not nullable do not
impact the
+ // nullability of the case expression.
+ if !is_nullable {
+ return None;
+ }
+
+ // For case-with-expression assume all 'then' expressions are
reachable
+ if self.body.expr.is_some() {
+ return Some(Ok(()));
+ }
+
+ // For branches with a nullable 'then' expression, try to
determine
Review Comment:
sure -- it sounds reasonable but I can't really tell without actually seeing
the code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
