Jefffrey commented on code in PR #18649:
URL: https://github.com/apache/datafusion/pull/18649#discussion_r2520454693
##########
datafusion/spark/src/function/bitwise/bit_shift.rs:
##########
@@ -18,36 +18,33 @@
use std::any::Any;
use std::sync::Arc;
-use arrow::array::{ArrayRef, ArrowPrimitiveType, AsArray, PrimitiveArray};
+use arrow::array::{ArrayRef, ArrowPrimitiveType, AsArray, Int32Array,
PrimitiveArray};
use arrow::compute;
use arrow::datatypes::{
ArrowNativeType, DataType, Int32Type, Int64Type, UInt32Type, UInt64Type,
Review Comment:
The trait is still needed for calling `get_byte_width` in the shift functions
```rust
let bit_num = (T::Native::get_byte_width() * 8) as i32;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
