rluvaton commented on PR #17977: URL: https://github.com/apache/datafusion/pull/17977#issuecomment-3529318348
As suspected up to : > From @alamb results this is the parsed as table: all below are for `PrimitiveGroupValueBuilder` `vectorize_equal_to` (note that there are sometimes some regression for some reason in some other function) | null | nullable | size | equal_to_results | main (ratio) | main (time) | optimize (ratio) | optimize (time) | |------|----------|--------|------------------|--------------|----------------|------------------|-----------------| | 0.0 | false | 1000 | 0.25 true | 1.23 | 868.4±42.82ns | 1.00 | 705.4±2.41ns | | 0.0 | false | 1000 | 0.5 true | 1.42 | 999.4±34.20ns | 1.00 | 704.4±0.88ns | | 0.0 | false | 1000 | 0.75 true | 2.06 | 1455.8±31.09ns | 1.00 | 705.7±2.72ns | | 0.0 | false | 1000 | all_true | 1.97 | 1387.0±3.29ns | 1.00 | 704.6±1.77ns | | 0.0 | false | 10000 | 0.25 true | 3.37 | 23.8±0.06µs | 1.00 | 7.1±0.08µs | | 0.0 | false | 10000 | 0.5 true | 5.00 | 35.4±0.09µs | 1.00 | 7.1±0.02µs | | 0.0 | false | 10000 | 0.75 true | 3.70 | 26.2±0.05µs | 1.00 | 7.1±0.02µs | | 0.0 | false | 10000 | all_true | 1.92 | 13.6±0.03µs | 1.00 | 7.1±0.02µs | | 0.0 | false | 100000 | 0.25 true | 3.61 | 267.4±0.79µs | 1.00 | 74.2±1.37µs | | 0.0 | false | 100000 | 0.5 true | 5.65 | 411.0±0.84µs | 1.00 | 72.7±0.50µs | | 0.0 | false | 100000 | 0.75 true | 4.02 | 292.4±0.93µs | 1.00 | 72.7±0.46µs | | 0.0 | false | 100000 | all_true | 1.90 | 138.6±0.38µs | 1.00 | 73.0±0.58µs | | 0.0 | true | 1000 | 0.25 true | 1.11 | 785.0±7.88ns | 1.00 | 706.9±1.20ns | | 0.0 | true | 1000 | 0.5 true | 1.46 | 1034.7±10.20ns | 1.00 | 706.8±1.02ns | | 0.0 | true | 1000 | 0.75 true | 1.93 | 1366.4±15.36ns | 1.00 | 706.6±0.75ns | | 0.0 | true | 1000 | all_true | 2.34 | 1650.0±10.52ns | 1.00 | 705.8±1.11ns | | 0.0 | true | 10000 | 0.25 true | 3.70 | 26.2±0.16µs | 1.00 | 7.1±0.04µs | | 0.0 | true | 10000 | 0.5 true | 5.67 | 40.1±0.18µs | 1.00 | 7.1±0.02µs | | 0.0 | true | 10000 | 0.75 true | 4.08 | 28.9±0.14µs | 1.00 | 7.1±0.02µs | | 0.0 | true | 10000 | all_true | 2.31 | 16.3±0.02µs | 1.00 | 7.1±0.02µs | | 0.0 | true | 100000 | 0.25 true | 3.98 | 289.2±2.11µs | 1.00 | 72.7±0.31µs | | 0.0 | true | 100000 | 0.5 true | 6.10 | 444.8±0.97µs | 1.00 | 72.9±1.19µs | | 0.0 | true | 100000 | 0.75 true | 4.37 | 327.1±1.65µs | 1.00 | 74.8±0.82µs | | 0.0 | true | 100000 | all_true | 2.28 | 165.6±0.54µs | 1.00 | 72.8±0.53µs | | 0.1 | true | 1000 | 0.25 true | 1.00 | 1102.2±6.86ns | 1.16 | 1278.7±46.97ns | | 0.1 | true | 1000 | 0.5 true | 1.00 | 1890.5±20.06ns | 1.07 | 2.0±0.01µs | | 0.1 | true | 1000 | 0.75 true | 1.00 | 2.7±0.01µs | 1.03 | 2.8±0.01µs | | 0.1 | true | 1000 | all_true | 1.00 | 3.6±0.01µs | 1.02 | 3.7±0.00µs | | 0.1 | true | 10000 | 0.25 true | 1.04 | 28.2±0.08µs | 1.00 | 27.0±0.13µs | | 0.1 | true | 10000 | 0.5 true | 1.00 | 52.0±0.23µs | 1.02 | 53.0±0.26µs | | 0.1 | true | 10000 | 0.75 true | 1.00 | 46.3±0.24µs | 1.01 | 46.8±0.27µs | | 0.1 | true | 10000 | all_true | 1.00 | 40.2±0.21µs | 1.02 | 41.2±0.10µs | | 0.1 | true | 100000 | 0.25 true | 1.00 | 346.0±1.50µs | 1.01 | 348.3±0.80µs | | 0.1 | true | 100000 | 0.5 true | 1.00 | 579.8±1.14µs | 1.02 | 589.5±1.03µs | | 0.1 | true | 100000 | 0.75 true | 1.00 | 521.2±0.97µs | 1.01 | 527.5±2.07µs | | 0.1 | true | 100000 | all_true | 1.00 | 423.5±1.02µs | 1.01 | 426.4±1.21µs | | 0.5 | true | 1000 | 0.25 true | 1.00 | 1029.3±10.48ns | 1.17 | 1203.0±8.82ns | | 0.5 | true | 1000 | 0.5 true | 1.00 | 1715.6±12.43ns | 1.09 | 1873.0±20.02ns | | 0.5 | true | 1000 | 0.75 true | 1.00 | 2.4±0.04µs | 1.05 | 2.5±0.02µs | | 0.5 | true | 1000 | all_true | 1.00 | 3.1±0.01µs | 1.06 | 3.2±0.04µs | | 0.5 | true | 10000 | 0.25 true | 1.01 | 32.9±0.13µs | 1.00 | 32.5±0.13µs | | 0.5 | true | 10000 | 0.5 true | 1.00 | 61.9±0.36µs | 1.00 | 61.9±0.49µs | | 0.5 | true | 10000 | 0.75 true | 1.00 | 62.8±0.36µs | 1.01 | 63.5±0.38µs | | 0.5 | true | 10000 | all_true | 1.00 | 59.2±0.50µs | 1.01 | 59.7±0.25µs | | 0.5 | true | 100000 | 0.25 true | 1.00 | 397.4±1.57µs | 1.01 | 402.1±0.96µs | | 0.5 | true | 100000 | 0.5 true | 1.00 | 677.9±1.53µs | 1.01 | 682.5±1.56µs | | 0.5 | true | 100000 | 0.75 true | 1.00 | 681.7±1.61µs | 1.01 | 689.3±1.01µs | | 0.5 | true | 100000 | all_true | 1.00 | 667.7±2.25µs | 1.01 | 671.2±1.33µs | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
