comphead commented on code in PR #18677: URL: https://github.com/apache/datafusion/pull/18677#discussion_r2525638113
########## datafusion/sqllogictest/test_files/aggregate.slt: ########## @@ -597,6 +597,86 @@ from data ---- 1 +# group correlation_query_with_nans_f32 +query IR +with data as ( + select 1 id, 1 as f, 'nan'::float as b + union all + select 2 id, 'nan'::float as f, 1 as b + union all + select 3 id, 'nan'::float as f, null as b + union all + select 4 id, null as f, 'nan'::float as b + union all + select 5 id, 'nan'::float as f, 'nan'::float as b + union all + select 5 id, 1 as f, 1 as b + union all + select 5 id, 2 as f, 2 as b + union all + select 6 id, 'nan'::float as f, 'nan'::float as b +) +select id, corr(f, b) +from data +group by id +order by id Review Comment: Agree, this syntax is more concise. Done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
