gabotechs commented on PR #18673: URL: https://github.com/apache/datafusion/pull/18673#issuecomment-3533313343
I think at this point there's a lot of subjectivity here. I personally prefer a less cluttered display that does not contain redundant information. Following that same rule I'd also expect other plans like `FilterExec` or `CoalesceBatchesExec` to display wether they are implicitly maintaining the input ordering or not, but we don't seem to be doing that here, and I agree that it would make the cluttering even worst. My point of view is that adding the extra information proposed in this PR is making the plan slightly less readable and slightly more confusing, so I cannot in good conscience give a +1 to this myself, but I'm not the only one reading plans here, so would love to hear opinions from other contributors and agree to what others think is best. Maybe @adriangb or @Jefffrey? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
