xanderbailey commented on code in PR #18712:
URL: https://github.com/apache/datafusion/pull/18712#discussion_r2529941903
##########
datafusion/physical-plan/src/aggregates/row_hash.rs:
##########
@@ -709,9 +709,21 @@ impl Stream for GroupedHashAggregateStream {
break 'reading_input;
}
- self.emit_early_if_necessary()?;
+ // Check if we should switch to skip aggregation
mode
+ // It's important that we do this before we early
emit since we've
+ // already updated the probe.
+ if let Some(new_state) =
self.switch_to_skip_aggregation()? {
Review Comment:
@korowa does that make sense to you?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
