xanderbailey commented on code in PR #18712:
URL: https://github.com/apache/datafusion/pull/18712#discussion_r2530030798
##########
datafusion/physical-plan/src/aggregates/row_hash.rs:
##########
@@ -832,6 +852,13 @@ impl Stream for GroupedHashAggregateStream {
}
ExecutionState::Done => {
+ // Sanity check: all groups should have been emitted by now
+ if !self.group_values.is_empty() {
Review Comment:
I'd rather fail the query than return the wrong / incomplete results.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
