foskey51 commented on code in PR #18695:
URL: https://github.com/apache/datafusion/pull/18695#discussion_r2529983634
##########
datafusion/datasource-parquet/src/source.rs:
##########
@@ -334,9 +334,9 @@ impl ParquetSource {
}
/// Set predicate information
- pub fn with_predicate(&self, predicate: Arc<dyn PhysicalExpr>) -> Self {
+ pub fn with_predicate(&self, predicate: &Arc<dyn PhysicalExpr>) -> Self {
Review Comment:
marked it with `#[expect(clippy::needless_pass_by_value)]`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
