foskey51 commented on code in PR #18695:
URL: https://github.com/apache/datafusion/pull/18695#discussion_r2529992355
##########
datafusion/datasource-parquet/src/file_format.rs:
##########
@@ -1074,9 +1074,9 @@ pub async fn fetch_statistics(
)]
pub fn statistics_from_parquet_meta_calc(
metadata: &ParquetMetaData,
- table_schema: SchemaRef,
+ table_schema: &SchemaRef,
Review Comment:
I did not find any references to this function (I guess bcz it was
deprecated after 50.0.0 and this `statistics_from_parquet_metadata` took over
it). So I ended up marking it with `#[expect(clippy::needless_pass_by_value)]`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
