EmilyMatt opened a new pull request, #18812:
URL: https://github.com/apache/datafusion/pull/18812
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
- Closes #18811 .
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
The main issue I was trying to solve is that despite the unreachable!()
block in the avro-to-arrow schema conversion, when providing an arrow schema to
the reader, the writer_schema from the file could still contain Ref types, and
we'd never know about it, there is no error handling there, the values would
simply return as Null.
This is much more severe than just crashing due to a not-yet-implemented
feature.
However I used this opportunity to implement this for the schema conversion
as well.
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
A new lookup method for the schema, both when resolving positions, and when
actually converting avro schemas to arrow schemas, this will let us resolve Ref
types under some constraints (Namely, arrow does not allow circular
dependencies in schema, I'm not sure how this could ever be accomplished
without some drastic changes in the way schemas are composed)
## Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are
they covered by existing tests)?
-->
Yes, added as many tests as I could think of.
## Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api
change` label.
-->
Not really, should just work out of the box.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
