EmilyMatt commented on code in PR #18812:
URL: https://github.com/apache/datafusion/pull/18812#discussion_r2541115567
##########
datafusion/datasource-avro/src/avro_to_arrow/arrow_array_reader.rs:
##########
@@ -41,19 +42,24 @@ use arrow::datatypes::{
};
use arrow::datatypes::{Fields, SchemaRef};
use arrow::error::ArrowError;
-use arrow::error::ArrowError::SchemaError;
use arrow::error::Result as ArrowResult;
use arrow::record_batch::RecordBatch;
use arrow::util::bit_util;
-use datafusion_common::arrow_err;
use datafusion_common::error::{DataFusionError, Result};
+use datafusion_common::{arrow_err, HashMap, HashSet};
use num_traits::NumCast;
use std::collections::BTreeMap;
use std::io::Read;
use std::sync::Arc;
type RecordSlice<'a> = &'a [&'a Vec<(String, Value)>];
+#[derive(Default)]
+pub struct NamesResolver {
Review Comment:
Shouldn't be pub at all tbh, thanks for the catch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
